[webkit-reviews] review denied: [Bug 26139] Implement onredo and onundo event handlers : [Attachment 120933] Patch

Tue Jan 3 09:38:12 PST 2012

Ryosuke Niwa <rniwa at webkit.org> has denied sknikam at gmail.com's request for
review:
Bug 26139: Implement onredo and onundo event handlers
https://bugs.webkit.org/show_bug.cgi?id=26139

Attachment 120933: Patch
https://bugs.webkit.org/attachment.cgi?id=120933&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120933&action=review

> LayoutTests/editing/undo/b26139.html:3
> +
> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> +<html xmlns="http://www.w3.org/1999/xhtml">

This is definitely not a XHTML 1.0 as onundo/onredo content attributes are not
defined in XHTML1.0.

> LayoutTests/editing/undo/b26139.html:15
> +		function()
> +		{
> +			alert( 'The "redo" event has been fired!' );
> +		});

Wrong indentation.

> LayoutTests/editing/undo/b26139.html:22
> +		function()
> +		{
> +			alert( 'The "undo" event has been fired!' );
> +		});
> +

Ditto.

> LayoutTests/editing/undo/b26139.html:30
> +RandomText: <input type="text" name="randomText" /><br />

This test doesn't do anything. And you're also not adding an expected result.
r- due to this. Please see http://trac.webkit.org/wiki#LayoutTests.