[webkit-reviews] review requested: [Bug 72017] [EFL] Add NULL checks after memory allocation : [Attachment 120943] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 3 07:14:35 PST 2012


Grzegorz <g.czajkowski at samsung.com> has asked  for review:
Bug 72017: [EFL] Add NULL checks after memory allocation
https://bugs.webkit.org/show_bug.cgi?id=72017

Attachment 120943: proposed patch
https://bugs.webkit.org/attachment.cgi?id=120943&action=review

------- Additional Comments from Grzegorz <g.czajkowski at samsung.com>
As a conclusion of above discussion NULL checking isn't needed in these cases.
I only replaced calling alloca to C++ new placement for three reasons:
1. alloca it is not very portable.
2. NULL checking isn't required as new never returns NULL,
3. in compliance with WebKit coding style.


More information about the webkit-reviews mailing list