[webkit-reviews] review granted: [Bug 75083] Indirect adjacency combinator has potential sublinear performance : [Attachment 120939] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Allan Sandfeld
<sandfeld at kde.org>'s request for review:
Bug 75083: Indirect adjacency combinator has potential sublinear performance
https://bugs.webkit.org/show_bug.cgi?id=75083

Attachment 120939: Patch
https://bugs.webkit.org/attachment.cgi?id=120939&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=120939&action=review


> Source/WebCore/ChangeLog:10
> +2011-12-28  Allan Sandfeld Jensen  <allan.jensen at nokia.com>
> +
> +	   Fix superlinear runtime of the rare case of multiple indirect
adjency combinators,
> +	   such as "li ~ li ~ li". The recursive matching algorithm now detects
cases
> +	   where all siblings have failed a check of a selector.
> +	   https://bugs.webkit.org/show_bug.cgi?id=75083
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Test: perf/nested-combined-selectors.html

If you look around in the ChangeLog, you see that the standard format is:

Bug title
<Bugzilla URL>

Reviewed by Foo.

Brief description.

Test: for/foo.html

Please follow that.