[webkit-reviews] review granted: [Bug 75467] [GTK] Fix scrollbars size with GTK+ 3.x : [Attachment 120925] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 3 03:16:48 PST 2012
Xan Lopez <xan.lopez at gmail.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 75467: [GTK] Fix scrollbars size with GTK+ 3.x
https://bugs.webkit.org/show_bug.cgi?id=75467
Attachment 120925: Patch
https://bugs.webkit.org/attachment.cgi?id=120925&action=review
------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=120925&action=review
I think I would just have one call to gtk_widget_path_iter_add_class and set
the right style class to a variable in the ifs, but other than that it looks OK
to me.
There are no tests that need updating because of this?
> Source/WebCore/platform/gtk/RenderThemeGtk3.cpp:92
> + gtk_widget_path_iter_add_class(path, 0, "arrow");
I suppose this does not use GTK_STYLE_CLASS_ARROW because it was added later?
More information about the webkit-reviews
mailing list