[webkit-reviews] review denied: [Bug 74455] Uint8ClampedArray support : [Attachment 120901] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 2 17:20:55 PST 2012
Filip Pizlo <fpizlo at apple.com> has denied Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>'s request for review:
Bug 74455: Uint8ClampedArray support
https://bugs.webkit.org/show_bug.cgi?id=74455
Attachment 120901: Patch
https://bugs.webkit.org/attachment.cgi?id=120901&action=review
------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=120901&action=review
Looks good so far, but I think I found a bug. :-)
> Source/JavaScriptCore/dfg/DFGAbstractState.cpp:736
> + break;
This is good, but aren't you missing cases in GetByVal and PutByVal?
More information about the webkit-reviews
mailing list