[webkit-reviews] review granted: [Bug 75411] Enable the [Supplemental] IDL on GTK/GObject : [Attachment 120843] WIP patch to see if build passes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 2 10:42:14 PST 2012


Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 75411: Enable the [Supplemental] IDL on GTK/GObject
https://bugs.webkit.org/show_bug.cgi?id=75411

Attachment 120843: WIP patch to see if build passes
https://bugs.webkit.org/attachment.cgi?id=120843&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120843&action=review


> Source/WebCore/bindings/gobject/GNUmakefile.am:467
> +	$(AM_V_GEN)$(PERL) -I$(WebCore)/bindings/scripts
$(WebCore)/bindings/scripts/generate-bindings.pl --include $(WebCore)/dom
--include $(WebCore)/html --include $(WebCore)/css --include $(WebCore)/page
--include $(WebCore)/xml --include $(WebCore)/svg --outputDir
"$(GENSOURCES_WEBKIT)" --defines "LANGUAGE_GOBJECT=1 $(gdom_feature_defines)"
--generator GObject --supplementalDependencyFile
$(SUPPLEMENTAL_DEPENDENCY_FILE) $<

I'm surprised that these includes aren't broken out into a variable, but I see
that's how this script worked before.


More information about the webkit-reviews mailing list