[webkit-reviews] review granted: [Bug 75435] [GTK] Use gdk_screen_get_monitor_workarea() when available for screenAvailableRect() : [Attachment 120879] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 75435: [GTK] Use gdk_screen_get_monitor_workarea() when available for
screenAvailableRect()
https://bugs.webkit.org/show_bug.cgi?id=75435

Attachment 120879: Patch
https://bugs.webkit.org/attachment.cgi?id=120879&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120879&action=review


Nice.

> Source/WebCore/platform/gtk/GtkVersioning.c:355
> +    int result = XGetWindowProperty(display, rootWindow, workArea, 0, 4 * 32
/* Mas len */, False, AnyPropertyType,

Mas len -> max length?

>> Source/WebCore/platform/gtk/GtkVersioning.h:121
>> +void gdk_screen_get_monitor_workarea(GdkScreen *screen, int monitor,
GdkRectangle *area);
> 
> The parameter name "screen" adds no information, so it should be removed. 
[readability/parameter_name] [5]

Go ahead and fix this one, I'd say.