[webkit-reviews] review granted: [Bug 71568] [GTK] Add a way to change web view settings in MiniBrowser : [Attachment 120874] Updated patch according to review comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 2 06:07:50 PST 2012


Philippe Normand <pnormand at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 71568: [GTK] Add a way to change web view settings in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=71568

Attachment 120874: Updated patch according to review comments
https://bugs.webkit.org/attachment.cgi?id=120874&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=120874&action=review


Thanks! Just a last thing to fix before landing, I didn't notice it during the
first review.

> Tools/MiniBrowser/gtk/BrowserSettingsDialog.c:131
> +    GParamSpec **properties =
g_object_class_list_properties(G_OBJECT_GET_CLASS(settings), &propertiesCount);


Looks like properties is leaked


More information about the webkit-reviews mailing list