[webkit-reviews] review denied: [Bug 75420] [CMake] Clean up some cruft from wtf's CMakeLists.txt : [Attachment 120849] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has denied Raphael Kubo da Costa
<kubo at profusion.mobi>'s request for review:
Bug 75420: [CMake] Clean up some cruft from wtf's CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=75420

Attachment 120849: Patch
https://bugs.webkit.org/attachment.cgi?id=120849&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120849&action=review


> Source/JavaScriptCore/ChangeLog:3
> +	   [CMake] Clean up some cruft from wtf's CMakeLists.txt

Nit: wtf => WTF

> Source/JavaScriptCore/wtf/CMakeLists.txt:-210
> -    "${CMAKE_SOURCE_DIR}/Source/ThirdParty"

Removing this line will break the build for ports that use the Mersenne Twister
pseudorandom number generator, including the WinCE and BlackBerry ports. Notice
the file Souece/ThirdParty/mt19937.ar.c is included in wtf/RandomNumber.cpp.