[webkit-reviews] review granted: [Bug 72411] No-op filter changes color output because of colorspace issues : [Attachment 129642] preempting the style bot

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Tim Horton <timothy_horton at apple.com>'s request for
review:
Bug 72411: No-op filter changes color output because of colorspace issues
https://bugs.webkit.org/show_bug.cgi?id=72411

Attachment 129642: preempting the style bot
https://bugs.webkit.org/attachment.cgi?id=129642&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=129642&action=review


> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:80
> +    CGColorSpaceRef linearSRGBSpace = deviceRGBColorSpaceRef();

I would have initialized this to 0 here…

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:92
> +    return linearSRGBSpace;

…and 0-checked it here, and only if it’s 0, call deviceRGBColorSpaceRef(). One
reason is to save that function call in the success case. The other is to avoid
returning 0 if CGColorSpaceCreateWithICCProfile() failed for some reason.