[webkit-reviews] review denied: [Bug 79901] Refactoring: HTMLContentSelector should be InsertionPoint-aware : [Attachment 129608] Patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 79901: Refactoring: HTMLContentSelector should be InsertionPoint-aware
https://bugs.webkit.org/show_bug.cgi?id=79901

Attachment 129608: Patch
https://bugs.webkit.org/attachment.cgi?id=129608&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=129608&action=review


> Source/WebCore/html/shadow/ContentSelectorQuery.cpp:43
> +    if (!insertionPoint->isContentElement()) {

Having these explicit type check is unfortunate.
Can you pull thee stuff up to InsertionPoint to make this code path more
straight?
My feeling is that we can just pull select() up and return empty or null in
HTMLShadowElement. Or we mihght able to add some polymorphic method to
InsertionPoint.

> Source/WebCore/html/shadow/ContentSelectorQuery.cpp:76
> +    if (!m_insertionPoint->isContentElement())

Ditto about type check.