[webkit-reviews] review granted: [Bug 79620] Appending ShadowRoot into an element should not cause crash. : [Attachment 129624] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 79620: Appending ShadowRoot into an element should not cause crash.
https://bugs.webkit.org/show_bug.cgi?id=79620

Attachment 129624: Patch
https://bugs.webkit.org/attachment.cgi?id=129624&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129624&action=review


> LayoutTests/fast/dom/shadow/shadow-root-append.html:25
> +    shouldBeNull('root.firstChild');

Should you be checking to see if the container has chlidren now?