[webkit-reviews] review denied: [Bug 59961] Implement DefaultParagraphSeparator execCommand, to let authors choose the default block element : [Attachment 129621] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Pablo Flouret
<pablof at motorola.com>'s request for review:
Bug 59961: Implement DefaultParagraphSeparator execCommand, to let authors
choose the default block element
https://bugs.webkit.org/show_bug.cgi?id=59961

Attachment 129621: Patch
https://bugs.webkit.org/attachment.cgi?id=129621&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129621&action=review


> Source/WebCore/editing/Editor.cpp:3028
> +PassRefPtr<HTMLElement>
Editor::createDefaultParagraphSeparatorElement(Document* document) const
> +{
> +    if (defaultParagraphSeparatorIsDiv())
> +	   return HTMLDivElement::create(document);
> +    return HTMLParagraphElement::create(document);

We don't want to have this function on Editor. We should just add this to
CompositeEditCommand instead.

> Source/WebCore/editing/Editor.h:407
> +    bool m_defaultParagraphSeparatorIsDiv; // Should be P otherwise.

Instead of saying that it should be p otherwise, please use enum.