[webkit-reviews] review requested: [Bug 79927] [chromium] Add clipping to scissor rect to CCOcclusionTracker : [Attachment 129618] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 29 19:42:33 PST 2012


Dana Jansens <danakj at chromium.org> has asked  for review:
Bug 79927: [chromium] Add clipping to scissor rect to CCOcclusionTracker
https://bugs.webkit.org/show_bug.cgi?id=79927

Attachment 129618: Patch
https://bugs.webkit.org/attachment.cgi?id=129618&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
- Moved the computation of the surface scissor rect over to RenderSurface*.
- Fixed naming of scissor/damage/clip.
- Removed the "bool clip" parameter passed around to the static inline
functions.

Making a CCFloatScissorRect that can be infinite cleans up this CL a whole lot.
What do you think?


More information about the webkit-reviews mailing list