[webkit-reviews] review granted: [Bug 79963] Make parser code not depend on NamedNodeMap : [Attachment 129571] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>'s request for review:
Bug 79963: Make parser code not depend on NamedNodeMap
https://bugs.webkit.org/show_bug.cgi?id=79963

Attachment 129571: Patch
https://bugs.webkit.org/attachment.cgi?id=129571&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129571&action=review


This looks great.  Thanks.

> Source/WebCore/dom/ElementAttributeData.h:38
> +class AttributeVector : public Vector<RefPtr<Attribute>, 4> {

It's slightly unclear to me whether having AttributeVector inherit from Vector
is the best approach (over having AttributeVector just have a Vector as a
member), but this seems to work fine.