[webkit-reviews] review canceled: [Bug 79078] Add HTML Popup API to ChromeClient : [Attachment 129387] Patch 2

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has canceled Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 79078: Add HTML Popup API to ChromeClient
https://bugs.webkit.org/show_bug.cgi?id=79078

Attachment 129387: Patch 2
https://bugs.webkit.org/attachment.cgi?id=129387&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129387&action=review


>> Source/WebCore/ChangeLog:13
>> +	    * html/HTMLPopupClient.h: Added.
> 
> I am sorry for jerking you around, but I don't think html is the right place
for this. I could be wrong, but I think this directory is loosely associated
with the "stuff in HTML spec." (aside from workers and some other stuff in HTML
spec that probably should've been its own spec anyway).
> 
> Since we have no intention of making this an author-facing API, perhaps this
should live in Source/page?
> 
> I also noticed that in https://bugs.webkit.org/show_bug.cgi?id=53961, you
actually create a new Page for the popup. Perhaps this should be called
something like a PagePopup?

page/PagePopup* sounds good.  I'll update the patch.