[webkit-reviews] review granted: [Bug 79657] [WK2] [GTK] [libsoup] SoupSession should use system CA : [Attachment 129453] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 79657: [WK2] [GTK] [libsoup] SoupSession should use system CA
https://bugs.webkit.org/show_bug.cgi?id=79657

Attachment 129453: Patch
https://bugs.webkit.org/attachment.cgi?id=129453&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129453&action=review


> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:236
> +    SoupSession* session = WebCore::ResourceHandle::defaultSession();
> +    g_object_set(session, SOUP_SESSION_SSL_STRICT, FALSE, NULL);

I'm really sorry about this back and forth in this patch, I really am. Before
landing I think we should move this to
Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp. Later we can add API to
WebKit2 to expose certificate errors to the client. By default it would accept
broken certificates.