[webkit-reviews] review requested: [Bug 79705] didNewFirstVisuallyNonEmptyLayout should be enhanced to look at size instead of a raw tally : [Attachment 129510] Patch that addresses some comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 29 13:41:59 PST 2012


Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 79705: didNewFirstVisuallyNonEmptyLayout should be enhanced to look at size
instead of a raw tally
https://bugs.webkit.org/show_bug.cgi?id=79705

Attachment 129510: Patch that addresses some comments
https://bugs.webkit.org/attachment.cgi?id=129510&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
This patch moves the totalArea function into the Region class and also only
does any adding/removing of relevant objects during the foreground paint phase.
I did not address Hyatt's concern about overlapping objects. We think it will
be uncommon for replaced elements to overlap on a page, and we fear that
Hyatt's solution of doing a fake paint could have a negative performance
impact.


More information about the webkit-reviews mailing list