[webkit-reviews] review granted: [Bug 79929] Autocomplete attribute should apply to textarea's. : [Attachment 129482] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Mike Fenton
<mifenton at rim.com>'s request for review:
Bug 79929: Autocomplete attribute should apply to textarea's.
https://bugs.webkit.org/show_bug.cgi?id=79929

Attachment 129482: Patch
https://bugs.webkit.org/attachment.cgi?id=129482&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129482&action=review


> Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:183
> +    return elementAttributeState(element, QualifiedName(nullAtom,
"autocorrect", nullAtom));

I would do

DEFINE_STATIC_LOCAL(AtomicString, autocorrect, ("autocorrect"));

> Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:191
> +AttributeState elementAttributeState(const Element* element, const
QualifiedName& attributeName)

'AttributeState' reads too generic for its scoped purposes, I would think.