[webkit-reviews] review denied: [Bug 79873] [BlackBerry] Upstream LayerCompositingThread.{h, cpp} : [Attachment 129415] patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Robin Cao
<robin.cao at torchmobile.com.cn>'s request for review:
Bug 79873: [BlackBerry] Upstream LayerCompositingThread.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=79873

Attachment 129415: patch
https://bugs.webkit.org/attachment.cgi?id=129415&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=129415&action=review


Not much wrong, but still some cleanup to do.

> Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.cpp:297
> +	   FloatQuad surfaceQuad = getTransformedRect(m_bounds,
IntRect(IntPoint(), m_bounds), drawTransform);

Better use IntPoint::zero

> Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.cpp:487
> +    if (layer)

Can combine these two lines.

> Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.cpp:679
> +	   ASSERT_NOT_REACHED();

Can combine with AnimatedPropertyBackgroundColor case, they do the same.

> Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.h:47
> +class SkBitmap;

Not used? Please clean it up and the includes above.