[webkit-reviews] review granted: [Bug 79733] nrwt: port/Driver needs to support per-test command line args : [Attachment 129361] patch to make chromium work, fix _start()

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 79733: nrwt: port/Driver needs to support per-test command line args
https://bugs.webkit.org/show_bug.cgi?id=79733

Attachment 129361: patch to make chromium work, fix _start()
https://bugs.webkit.org/attachment.cgi?id=129361&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129361&action=review


> Tools/ChangeLog:14
> +	   This change adds support for that and removes the no-longer
> +	   needed public Driver.start() method (which no one was calling).

This part isn't true anymore, right?

> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:-223
> +	       driver.start()
>	       if self._options.pause_before_testing:
> -		   driver.start()

Why is this change necessary?