[webkit-reviews] review granted: [Bug 79812] Full screen video volume slider has "progress bar" : [Attachment 129355] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 79812: Full screen video volume slider has "progress bar"
https://bugs.webkit.org/show_bug.cgi?id=79812

Attachment 129355: Patch
https://bugs.webkit.org/attachment.cgi?id=129355&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=129355&action=review


> Source/WebCore/rendering/RenderThemeMac.h:161
> +    virtual bool paintMediaFullScreenVolumeSliderTrack(RenderObject*, const
PaintInfo&, const IntRect&);
> +    virtual bool paintMediaFullScreenVolumeSliderThumb(RenderObject*, const
PaintInfo&, const IntRect&);

The new WebKit hottness is to mark virtual overrides with OVERRIDE. All the
cool kids are doing it, you should too!