[webkit-reviews] review denied: [Bug 79896] [CMake][DRT] Add WebCoreTestSupport : [Attachment 129428] Patch

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has denied Kangil Han
<kangil.han at samsung.com>'s request for review:
Bug 79896: [CMake][DRT] Add WebCoreTestSupport
https://bugs.webkit.org/show_bug.cgi?id=79896

Attachment 129428: Patch
https://bugs.webkit.org/attachment.cgi?id=129428&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=129428&action=review


> Source/WebCore/ChangeLog:11
> +	   No new tests - just CMake changes for DRT.

IMO including this line makes no sense (it adds so additional info), but it's
ok to keep it.

> Source/WebCore/CMakeLists.txt:2539
> +    INSTALL(TARGETS ${WebCore_LIBRARY_NAME}
${WebCoreTestSupport_LIBRARY_NAME} DESTINATION lib)

do you really want to INSTALL WebCoreTestSupport?

> Source/WebCore/UseJSC.cmake:281
> +    LIST(APPEND IDL_FILES_LIST "${IDL_FILES_LIST}${WEBCORE_DIR}/${_idl}\n")

no need for LIST(APPEND), you set the variable with a value already including
the old value.

> Source/WebCore/UseV8.cmake:267
> +    LIST(APPEND IDL_FILES_LIST "${IDL_FILES_LIST}${WEBCORE_DIR}/${_idl}\n")

LIST(APPEND) -> SET()