[webkit-reviews] review denied: [Bug 79889] MediaStream API: MediaStreamTrackList out-of-bounds access fix : [Attachment 129424] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 29 03:01:25 PST 2012


Nikolas Zimmermann <zimmermann at kde.org> has denied Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 79889: MediaStream API: MediaStreamTrackList out-of-bounds access fix
https://bugs.webkit.org/show_bug.cgi?id=79889

Attachment 129424: Patch
https://bugs.webkit.org/attachment.cgi?id=129424&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129424&action=review


> Source/WebCore/ChangeLog:7
> +	   this is not according to ecmascript standard. Also fixed a similal
issue in MediaStreamList.

typo: similar.

> Source/WebCore/ChangeLog:9
> +	   Reviewed by NOBODY (OOPS!).

This line should be placed before your text.

> LayoutTests/ChangeLog:7
> +	   this is not according to ecmascript standard. Also fixed a similal
issue in MediaStreamList.

typo: similar.

> LayoutTests/ChangeLog:8
> +

Can you leave a word here, why the result says FAIL, so it's not as confusing
:-)

> LayoutTests/ChangeLog:9
> +	   Reviewed by NOBODY (OOPS!).

This line should be placed before your text.


More information about the webkit-reviews mailing list