[webkit-reviews] review denied: [Bug 67764] Crash in WebCore::CompositeEditCommand::insertNodeAt : [Attachment 129416] Updated Patch

Wed Feb 29 02:01:54 PST 2012

Ryosuke Niwa <rniwa at webkit.org> has denied Parag Radke <parag at motorola.com>'s
request for review:
Bug 67764: Crash in WebCore::CompositeEditCommand::insertNodeAt
https://bugs.webkit.org/show_bug.cgi?id=67764

Attachment 129416: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=129416&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129416&action=review

Please address nits below.

> Source/WebCore/ChangeLog:8
> +	   If caret position after deletion and destination position coinsides
than

Nit: s/ than/, then/

> LayoutTests/editing/deleting/delete-block-merge-contents-025-expected.txt:1
> +This is to test a usecase in which caret position after deletion and the
destination position where to move the paragraph, coinsides. To pass this
testcase it should not crash.

Same comment about "where to move the paragraph, ".

> LayoutTests/editing/deleting/delete-block-merge-contents-025.html:1
> +<html>

No DOCTYPE?