[webkit-reviews] review granted: [Bug 79790] Introduce SMIL overrideStyle, to make SVG stop mutating CSS styles directly : [Attachment 129412] Patch v3

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 79790: Introduce SMIL overrideStyle, to make SVG stop mutating CSS styles
directly
https://bugs.webkit.org/show_bug.cgi?id=79790

Attachment 129412: Patch v3
https://bugs.webkit.org/attachment.cgi?id=129412&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=129412&action=review


r=me, with some tweaks.

> Source/WebCore/css/CSSStyleSelector.cpp:765
> +inline bool CSSStyleSelector::addMatchedPropertiesIfPossible(MatchResult&
result, StylePropertySet* properties)
> +{

Something like addElementStyleProperties would be a better name. 

Instead of returning a bool, this should take a bool argument that tells if the
property set is cacheable (setting result.isCacheable = false if needed).

> Source/WebCore/css/CSSStyleSelector.h:295
> +    inline bool addMatchedPropertiesIfPossible(MatchResult&,
StylePropertySet*);

inline keyword here does nothing and should be removed.