[webkit-reviews] review granted: [Bug 78028] Decouple scrollbar painting from Scrollbar object : [Attachment 129332] Changes as per jamesr

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Peter Kotwicz
<pkotwicz at chromium.org>'s request for review:
Bug 78028: Decouple scrollbar painting from Scrollbar object
https://bugs.webkit.org/show_bug.cgi?id=78028

Attachment 129332: Changes as per jamesr
https://bugs.webkit.org/attachment.cgi?id=129332&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129332&action=review


Awesome! This looks great, R=me.  There are two more issues to address before
landing and I also think it's prudent to let the EWS bots go green just to be
safe.

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

this will trigger an SVN presubmit check and barf. since this is a refactor and
not a change of behavior you aren't required to add new tests, but you do have
to delete this line. it would be great if you could instead provide a brief
summary of the changes

> Source/WebCore/ChangeLog:11
> +	   * WebCore.gypi:
> +	   * WebCore.xcodeproj/project.pbxproj:

can you also add this new header file to the other build systems we have? not
all build systems list headers, but looking at references to ScrollbarTheme.h i
think you will want to modify:

Source/WebCore/GNUmakefile.list.am
Source/WebCore/Target.pri
Source/WebCore/WebCore.vcproj/WebCore.vcproj