[webkit-reviews] review granted: [Bug 79712] Clipboard::getData should return an empty string instead of undefined : [Attachment 129149] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 79712: Clipboard::getData should return an empty string instead of
undefined
https://bugs.webkit.org/show_bug.cgi?id=79712

Attachment 129149: Patch
https://bugs.webkit.org/attachment.cgi?id=129149&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129149&action=review


It seems unfortunate that you can't tell if something is in the clipboard or
just an empty string, but maybe that's intentional.

What does Firefox do?

> Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:452
> +    if (!getWebLocData(dataObject, url, title)) {

Nit: Can we early return here instead of nesting?