[webkit-reviews] review granted: [Bug 79737] nrwt: implement simple 'virtual test suite' support : [Attachment 129173] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 79737: nrwt: implement simple 'virtual test suite' support
https://bugs.webkit.org/show_bug.cgi?id=79737

Attachment 129173: Patch
https://bugs.webkit.org/attachment.cgi?id=129173&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129173&action=review


Thanks!

> Tools/Scripts/webkitpy/layout_tests/port/base.py:1061
> +	   class VirtualTestSuite(object):

Can we move this declaration to the top-level?	It seems like folks should just
call the constructor rather than calling the virtual_suite method.

> Tools/Scripts/webkitpy/layout_tests/port/base.py:1074
> +	   if self._populated_virtual_test_suites is None:

Should we make this function @memoized?