[webkit-reviews] review granted: [Bug 79816] More Pasteboard code cleanup : [Attachment 129301] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 28 12:06:06 PST 2012


Alexey Proskuryakov <ap at webkit.org> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 79816: More Pasteboard code cleanup
https://bugs.webkit.org/show_bug.cgi?id=79816

Attachment 129301: Patch
https://bugs.webkit.org/attachment.cgi?id=129301&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129301&action=review


> Source/WebCore/editing/mac/EditorMac.mm:286
> +    types.append(String(NSStringPboardType));

Is the explicit construction necessary here?

> Source/WebCore/platform/mac/PasteboardHelper.h:-43
> -    class PasteboardHelper {

I love to see "helper" pseudo-classes gone!


More information about the webkit-reviews mailing list