[webkit-reviews] review granted: [Bug 79811] Reimplement pathFromFont() in SimpleFontDataMac.mm : [Attachment 129296] Proposed changes.

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted nholbrook at apple.com's request for review:
Bug 79811: Reimplement pathFromFont() in SimpleFontDataMac.mm
https://bugs.webkit.org/show_bug.cgi?id=79811

Attachment 129296: Proposed changes.
https://bugs.webkit.org/attachment.cgi?id=129296&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=129296&action=review


OK. I think you could have just as well removed this function and changed its
callers.

> Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm:85
> +static NSString* pathFromFont(NSFont* font)

Spaces should go before the star in Objective-C objects (I know this was
already wrong in some of this code).

> Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm:87
> +    return [[[font fontDescriptor]
objectForKey:(NSString*)kCTFontURLAttribute] path];

Needs a space before the *.