[webkit-reviews] review denied: [Bug 79790] Introduce SMIL overrideStyle, to make SVG stop mutating CSS styles directly : [Attachment 129255] Patch v2

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 79790: Introduce SMIL overrideStyle, to make SVG stop mutating CSS styles
directly
https://bugs.webkit.org/show_bug.cgi?id=79790

Attachment 129255: Patch v2
https://bugs.webkit.org/attachment.cgi?id=129255&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=129255&action=review


> Source/WebCore/svg/SVGElement.h:112
> +    CSSStyleDeclaration* overrideStyle() { return
ensureOverrideStyleDecl()->ensureInlineCSSStyleDeclaration(this); }

This is wrong. OverrideStyle is not exposed in the DOM. There are no valid
reasons to instantiate an external API object (CSSStyleDeclaration) for it.