[webkit-reviews] review granted: [Bug 77554] [Qt] Allow read/write to the WebView.url property : [Attachment 129152] patch

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has granted Mahesh Kulkarni
<mahesh.kulkarni at nokia.com>'s request for review:
Bug 77554: [Qt] Allow read/write to the WebView.url property
https://bugs.webkit.org/show_bug.cgi?id=77554

Attachment 129152: patch
https://bugs.webkit.org/attachment.cgi?id=129152&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129152&action=review


Spelling issue for the variable, otherwise ok

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:158
> +    if (m_defferedUrlToLoad.isEmpty())

deferred

> Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h:164
> +    QUrl m_defferedUrlToLoad;

deferred

>
Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qm
l:96
> +	    webView.url = testUrl

indentation