[webkit-reviews] review granted: [Bug 57505] getComputedStyle fails for 'first-line' pseudo-element : [Attachment 129221] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Alexis Menard (darktears)
<alexis.menard at openbossa.org>'s request for review:
Bug 57505: getComputedStyle fails for 'first-line' pseudo-element
https://bugs.webkit.org/show_bug.cgi?id=57505

Attachment 129221: Patch
https://bugs.webkit.org/attachment.cgi?id=129221&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129221&action=review


> Source/WebCore/ChangeLog:14
> +	   No new tests : I updated the expectation of one.

Please name the test that you updated here.

>
LayoutTests/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html
:70
> -	   { 'elementId' : 'testNoPseudoElement', 'pseudoElement' :
':first-line', 'property' : 'color', 'expectedValue' : '' },
> +	   { 'elementId' : 'testNoPseudoElement', 'pseudoElement' :
':first-line', 'property' : 'color', 'expectedValue' : 'rgb(165, 42, 42)' },

Can we add test cases for more pseudo styles?