[webkit-reviews] review denied: [Bug 79787] Do not interate all tiles for resizing when the content didn't change : [Attachment 129265] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 28 10:02:06 PST 2012


Noam Rosenthal <noam.rosenthal at nokia.com> has denied  review:
Bug 79787: Do not interate all tiles for resizing when the content didn't
change
https://bugs.webkit.org/show_bug.cgi?id=79787

Attachment 129265: Patch
https://bugs.webkit.org/attachment.cgi?id=129265&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=129265&action=review


r- based on jocelyn's comments.

>> Source/WebCore/platform/graphics/TiledBackingStore.cpp:236
>> +	const IntRect& visibleRect = visibleContentsRect();
> 
> Is it OK to use a reference here?

I think it doesn't add much to use references. Let's use regular assignment.


More information about the webkit-reviews mailing list