[webkit-reviews] review denied: [Bug 79691] Web Inspector: [InspectorIndexedDB] Show meaningful description for object store items values. : [Attachment 129081] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 28 09:51:28 PST 2012


Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 79691: Web Inspector: [InspectorIndexedDB] Show meaningful description for
object store items values.
https://bugs.webkit.org/show_bug.cgi?id=79691

Attachment 129081: Patch
https://bugs.webkit.org/attachment.cgi?id=129081&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129081&action=review


> Source/WebCore/inspector/front-end/IndexedDBViews.js:349
> +	       span.appendChild(document.createTextNode("\"" +
value.description + "\""));

Appending blob will kill the renderer.

> Source/WebCore/inspector/front-end/IndexedDBViews.js:352
> +	   default:

What about the number, null, undefined?


More information about the webkit-reviews mailing list