[webkit-reviews] review granted: [Bug 79792] Web Inspector: preserve memory counters size after frontend reopening : [Attachment 129253] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 28 08:12:13 PST 2012


Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 79792: Web Inspector: preserve memory counters size after frontend
reopening
https://bugs.webkit.org/show_bug.cgi?id=79792

Attachment 129253: Patch
https://bugs.webkit.org/attachment.cgi?id=129253&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129253&action=review


> Source/WebCore/inspector/front-end/TimelinePanel.js:66
> +	   WebInspector.settings.memoryCounterGraphsHeight =
WebInspector.settings.createSetting("memoryCounterGraphsHeight", 600);

Inspector's default height is 600, this should be 150.

> Source/WebCore/inspector/front-end/TimelinePanel.js:175
> +	   WebInspector.settings.memoryCounterGraphsHeight.set(top);

this should be a part of _endSplitterDragging.


More information about the webkit-reviews mailing list