[webkit-reviews] review granted: [Bug 76445] [Qt] build-webkit does not detect the number of CPUs : [Attachment 125611] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 28 07:53:32 PST 2012


Csaba Osztrogonac <ossy at webkit.org> has granted János Badics
<jbadics at inf.u-szeged.hu>'s request for review:
Bug 76445: [Qt] build-webkit does not detect the number of CPUs
https://bugs.webkit.org/show_bug.cgi?id=76445

Attachment 125611: proposed patch
https://bugs.webkit.org/attachment.cgi?id=125611&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
LGTM, r=me.

>(From update of attachment 125611 [details])
>Entertaining.	There is also code for this in webkitpy/common/ports.py
I don't think if it is entartaining, but a necessary change, because 
Tools/Scripts/build-webkit doesn't use webkitpy/common/ports.py ,
but many developers and bots use build-webkit script.


More information about the webkit-reviews mailing list