[webkit-reviews] review granted: [Bug 79759] [EFL] Implementation of missing functions in GraphicsContext3DPrivate : [Attachment 129204] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has granted Hyowon Kim
<hw1008.kim at samsung.com>'s request for review:
Bug 79759: [EFL] Implementation of missing functions in
GraphicsContext3DPrivate
https://bugs.webkit.org/show_bug.cgi?id=79759

Attachment 129204: Patch
https://bugs.webkit.org/attachment.cgi?id=129204&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=129204&action=review


LGTM, except a couple of nitpicks - please fix before committing.

> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:434
> +    if (m_syntheticErrors.size() > 0) {

Use .isEmpty()

> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:463
> +	   *value /= 4;

Comment for why this is /4