[webkit-reviews] review granted: [Bug 79667] [GTK] Add method webkit_web_resource_get_data() to WebKit2 GTK+ API : [Attachment 129029] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 79667: [GTK] Add method webkit_web_resource_get_data() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=79667

Attachment 129029: Patch
https://bugs.webkit.org/attachment.cgi?id=129029&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129029&action=review


+1

> Source/WebKit2/UIProcess/API/gtk/WebKitWebResource.cpp:346
> + *	 of error. Set @length to a #gsize to get the length of the string.

I'd say 'if @length is not %NULL, the size of the data will be assigned to it',
also, I would avoid using 'string' in any of these, because they are often not
strings.