[webkit-reviews] review denied: [Bug 79754] [Forms] Spin button sometimes ignores Indeterminate of m_upDownState : [Attachment 129209] Patch 1

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 79754: [Forms] Spin button sometimes ignores Indeterminate of m_upDownState
https://bugs.webkit.org/show_bug.cgi?id=79754

Attachment 129209: Patch 1
https://bugs.webkit.org/attachment.cgi?id=129209&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129209&action=review


> Source/WebCore/html/shadow/TextControlInnerElements.cpp:-297
> -		   ASSERT(m_upDownState != Indeterminate);

If you think this assertion should be removed, please write a reason in
ChangeLog.

> Source/WebCore/html/shadow/TextControlInnerElements.cpp:299
> +		   if (m_upDownState != Indeterminate) {
> +		     input->stepUpFromRenderer(m_upDownState == Up ? 1 : -1);
> +		     if (renderer())

Wrong indentation.