[webkit-reviews] review requested: [Bug 79663] Move WebSocket APIs from WorkerContext.idl to WorkerContextWebSocket.idl : [Attachment 129018] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has asked  for review:
Bug 79663: Move WebSocket APIs from WorkerContext.idl to
WorkerContextWebSocket.idl
https://bugs.webkit.org/show_bug.cgi?id=79663

Attachment 129018: Patch
https://bugs.webkit.org/attachment.cgi?id=129018&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
(In reply to comment #6)
> (From update of attachment 129018 [details])
> So let's move the discussion further.

ap: As we have discussed in the webkit-dev@ thread, we are trying to do the
following two things:

[1] Move "self-contained" features from WebCore to WebCore/Modules/.
[2] Make DOMWindow.idl less epic (like moving HTML-related APIs to
DOMWindowHTML.idl)

As far as I understand the discussion, while [2] is controversial, we are
reaching a consensus on [1] (although we should have taken more care of
licences, as you pointed out).

This patch is categorized to [1]. WebSocket is a self-contained feature and can
be split out of WebCore beautifully. The benefit is as follows, as Adam pointed
out:

> As a result of this process, folks hacking on WebCore proper won't encounter
WebSocket-specific code anymore.  All the WebSocket-specific code has been
moved to the Modules/websockets directory.  If we repeat this refactoring for
the many features where it's appropriate, that makes it easier to hack on
WebCore proper.

Wouldn't it make sense?

ap: review?