[webkit-reviews] review granted: [Bug 79566] Fixed a typo in CanvasRenderingContext2D::drawImage(HTMLCanvasElement); incorrect source and destination rect used : [Attachment 129112] patch v.3

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 79566: Fixed a typo in
CanvasRenderingContext2D::drawImage(HTMLCanvasElement); incorrect source and
destination rect used
https://bugs.webkit.org/show_bug.cgi?id=79566

Attachment 129112: patch v.3
https://bugs.webkit.org/attachment.cgi?id=129112&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129112&action=review


> Source/WebCore/ChangeLog:11
> +	   I amended canvas-composite-canvas to cover this bug, and I also
amended
> +	   canvas-composite-image because I changed
> +	   LayoutTests/fast/canvas/resources/canvas-composite-image-common.js.
> +	   However, the change of canvas-composite-image is reasonable because
> +	   drawImage(HTMLImageElement) will be able to have a similar bug.

Did you mean to use the same description in the WebCore change log? I suggest
writing something specific to the WebCore change in this change log entry,
like:
"Pass dstRect and bufferSrcRect to
CanvasRenderingContext2D::fullCanvasCompositedDrawImage() for the destination
and source rect, respectively."