[webkit-reviews] review granted: [Bug 79580] Extract the logic for computing the dirty rows / columns out of RenderTableSection::paintObject : [Attachment 129093] Corrected wrong parentheses pointed out by Robert.

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 79580: Extract the logic for computing the dirty rows / columns out of
RenderTableSection::paintObject
https://bugs.webkit.org/show_bug.cgi?id=79580

Attachment 129093: Corrected wrong parentheses pointed out by Robert.
https://bugs.webkit.org/attachment.cgi?id=129093&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129093&action=review


LGTM.

> Source/WebCore/rendering/RenderTableSection.cpp:1064
> +    // FIXME: Why do we double the outline size?
> +    LayoutUnit outlineSize = 2 * maximalOutlineSize(paintPhase);

I suspect it was an attempt to deal with the fact that outline would appear
equally on both sides of the rect.  Now using inflate it's obvious that 2x is
wrong.	But it's unclear from the original code if 2x was wrong.

> Source/WebCore/rendering/RenderTableSection.h:42
>  
> +// Helper class for paintObject.
> +class CellSpan {
> +public:

It's possible that the whole paintObject function should move onto a helper
object which existed just to contain table-paint-related logic.