[webkit-reviews] review denied: [Bug 79490] Percent width/height SVG not always scaled on window resize : [Attachment 129066] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Florin Malita
<fmalita at google.com>'s request for review:
Bug 79490: Percent width/height SVG not always scaled on window resize
https://bugs.webkit.org/show_bug.cgi?id=79490

Attachment 129066: Patch
https://bugs.webkit.org/attachment.cgi?id=129066&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129066&action=review


Almost there, still some perf issues that should be resolved:

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1489
> +		   if (relayoutChildren || box->hasRelativeLogicalWidth() ||
box->hasRelativeLogicalHeight())

Hm, I think you can now merge these two methods. no place needs either width or
height information, all callers need both width and height info.
To avoid doing two virtual calls, just use hasRelativeDimensions() - this way
you can also omit the logical everywhere, as it won't matter.

Note: You're also changing HTML behavior here, which is probably a bug fix.
maxWidth/maxHeight is now included in this check. Needs a testcase.

> Source/WebCore/rendering/RenderBox.cpp:3967
> +

One newline too much.