[webkit-reviews] review denied: [Bug 75824] check-webkit-style should warn about missing svn:mime-type for png files : [Attachment 129058] patch (work in progress)

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Balazs Ankes <bank at inf.u-szeged.hu>'s
request for review:
Bug 75824: check-webkit-style should warn about missing svn:mime-type for png
files
https://bugs.webkit.org/show_bug.cgi?id=75824

Attachment 129058: patch (work in progress)
https://bugs.webkit.org/attachment.cgi?id=129058&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129058&action=review


I think checking to see if the user's subversion config file is correct is
useful, however, that doesn't actually fix this specific bug where certain
files might not have the right svn properties set.  I.e., this should probably
be a separate bug.

> Tools/Scripts/webkitpy/style/checkers/png.py:25
>  """Supports checking WebKit style in png files."""

This diff is weird.  I don't see png.py in the tree currently.

> Tools/Scripts/webkitpy/style/checkers/png.py:42
> +	       for line in open(os.path.expanduser("~") +
"/.subversion/config", 'r').readlines():

Does this work with Windows python?  Does this work with Windows svn?

> Tools/Scripts/webkitpy/style/patchreader.py:65
> +		   _log.debug("Using class: " + checker.__class__.__name__)

I would remove this log line.