[webkit-reviews] review denied: [Bug 79206] REGRESSION(r106388): Form state is restored to a wrong document : [Attachment 128961] Patch 3

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 79206: REGRESSION(r106388): Form state is restored to a wrong document
https://bugs.webkit.org/show_bug.cgi?id=79206

Attachment 128961: Patch 3
https://bugs.webkit.org/attachment.cgi?id=128961&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128961&action=review


> Source/WebCore/loader/HistoryController.cpp:206
> +    if (itemToRestore->isCurrentDocument(doc)) {
> +	   LOG(Loading, "WebCoreLoading %s: restoring form state from %p",
m_frame->tree()->uniqueName().string().utf8().data(), itemToRestore);
> +	   doc->setStateForNewFormElements(itemToRestore->documentState());
> +    }

Doesn't this code do the exact same wrong thing Adam and I alluded to? 

(HistoryItem::isCurrentDocument() just does a URL compare)