[webkit-reviews] review denied: [Bug 79566] Fixed a typo in CanvasRenderingContext2D::drawImage(HTMLCanvasElement); incorrect source and destination rect used : [Attachment 129002] patch v.2

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 79566: Fixed a typo in
CanvasRenderingContext2D::drawImage(HTMLCanvasElement); incorrect source and
destination rect used
https://bugs.webkit.org/show_bug.cgi?id=79566

Attachment 129002: patch v.2
https://bugs.webkit.org/attachment.cgi?id=129002&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129002&action=review


This patch looks good to me, but we need a change log entry for the layout test
changes.

You may also want to add a remark in the layout test change log entry that this
patch only affects the results of 
LayoutTests/fast/canvas/canvas-composite-canvas.html and that the changes made
to canvas-composite-image.html are a side effect of the change made to
LayoutTests/fast/canvas/resources/canvas-composite-image-common.js.

> LayoutTests/ChangeLog:3
> +	   Fixed a typo of Canvas drawImage(canvas).

Nit: I updated the title of this bug to elaborate on the typo. For consistency,
we should update this line to match the updated bug title. The updated title is
a bit verbose. Feel free to come up with an alternative bug title.