[webkit-reviews] review requested: [Bug 75824] check-webkit-style should warn about missing svn:mime-type for png files : [Attachment 129058] patch (work in progress)

[bugzilla-daemon at webkit.org]

Balazs Ankes <bank at inf.u-szeged.hu> has asked  for review:
Bug 75824: check-webkit-style should warn about missing svn:mime-type for png
files
https://bugs.webkit.org/show_bug.cgi?id=75824

Attachment 129058: patch (work in progress)
https://bugs.webkit.org/attachment.cgi?id=129058&action=review

------- Additional Comments from Balazs Ankes <bank at inf.u-szeged.hu>
I made a png.py file which check the ~/.subversion/config file the auto propset
and svn:mime-type=image/png are enabled (based on
ttp://trac.webkit.org/wiki/UsingGitWithWebKit Misc. Tips and Tricks) because in
git svn there is no propset command. Only auto propset can set the mimetype.
I have some question.
- Is it enough to check the config file?
- I noticed check-webkit-style doesn't support non-text files. I tried to solve
the task elegant, but I think I couldn't. What should I do?
- If there is a style error related with pngs I want to add to the global error
counter. How can I do this nicely?
Any ideas that should be implement?

(I know I have to write unit tests.)