[webkit-reviews] review granted: [Bug 79649] Web Inspector: WebKit2: need API to when the Inspector is in the front : [Attachment 129049] Proposed Change (round 2)

[bugzilla-daemon at webkit.org]

John Sullivan <sullivan at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 79649: Web Inspector: WebKit2: need API to when the Inspector is in the
front
https://bugs.webkit.org/show_bug.cgi?id=79649

Attachment 129049: Proposed Change (round 2)
https://bugs.webkit.org/attachment.cgi?id=129049&action=review

------- Additional Comments from John Sullivan <sullivan at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=129049&action=review


> Source/WebCore/ChangeLog:8
> +

Needs a bug number here.

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:95
> +}

Is there something preventing us from updating the method name to
showOrHideWebInspector: or something along those lines?

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:254
> +    // FIXME: this will not bring a background tab in Safari to the front,
only its window. <rdar://problem/10937688>

Our normal style is "FIXME 10937688:" or "FIXME <rdar://problem/10937688>".

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:260
> +    // FIXME: this will not return false for a background tab in Safari,
only a background window. <rdar://problem/10937688>

Same here.